Allow import language.experimental.captureChecking in the REPL #16304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #16250 with @rjolly during the issue spree.
Two things currently seem to prevent
import language.experimental.captureCheckingto be used in the REPL.1.
needsCaptureCheckingflag preservation across compilation unitsThe
needsCaptureCheckingis defined here:scala3/compiler/src/dotty/tools/dotc/CompilationUnit.scala
Line 57 in b5941e4
And is set from
handleGlobalLanguageImport:scala3/compiler/src/dotty/tools/dotc/config/Feature.scala
Line 153 in b5941e4
To preserve it, we tried calling
handleGlobalLanguageImportinsetImportInfo(4702968).2. outermost syntax errror
Currently, a syntax error is emitted if the import is not at the top level:
scala3/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
Lines 3312 to 3313 in b5941e4
Outermost is originally set here:
scala3/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
Line 764 in b5941e4
We are not sure yet if and how we should special-case this flag so that it works with wrapper objects generated by the REPL.